[PATCH] D18106: Extract out a SelectionDAGBuilder::LowerAsStatepoint; NFC

[Sanjoy Das via llvm-commits]

sanjoy added a comment.

Hi Philip,

In http://reviews.llvm.org/D18106#373810, @reames wrote:

> A couple of minor comments for now.  I'm going to return to this Monday.  FYI, the organization of this is really bugging me.  Hopefully, I'll be able to explain why with a bit more thought.  :)


If you're concerned about this not being general enough to support
deopt bundle lowering also (i.e. the coupling is too tight), then I
think you're right -- as I've mentioned in the commit message, I'm
fairly sure that I'll have to evolve the `LowerAsStatepoint` interface
somewhat to support both use cases.  If you want, I can wait on
getting this reviewed till I'm done with the full implementation of
deopt bundle lowering (and get them reviewed at the same time, but as
different patches).

Or are you concerned about some other aspect of this patch?


http://reviews.llvm.org/D18106