[test-suite] r263182 - Add cmake caches for common configurations

[Chris Matthews via llvm-commits]

Thanks.  Fixed in r263306.

> On Mar 11, 2016, at 12:27 PM, Justin Bogner via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Chris Matthews via llvm-commits <llvm-commits at lists.llvm.org> writes:
>> Author: cmatthews
>> Date: Thu Mar 10 19:26:06 2016
>> New Revision: 263182
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=263182&view=rev
>> Log:
>> Add cmake caches for common configurations
>> 
>> There are some common configurations of the test-suite which really
>> should be encoded right into the test-suite so they can be easily used
>> and shared.
>> 
>> This commit adds new cmake caches to start to capture those configs.
>> Release is a production build where we enable -O3 and LTO.  Debug, is
>> what a developer might use on their desktop while working on code, with
>> the flags -O0 -g.
>> 
>> Watch for a matching LNT commit which adds support for using these.
>> 
>> Added:
>>    test-suite/trunk/cmake/caches/
>>    test-suite/trunk/cmake/caches/Debug.cmake
>>    test-suite/trunk/cmake/caches/Release.cmake
>> 
>> Added: test-suite/trunk/cmake/caches/Debug.cmake
>> URL:
>> http://llvm.org/viewvc/llvm-project/test-suite/trunk/cmake/caches/Debug.cmake?rev=263182&view=auto
>> ==============================================================================
>> --- test-suite/trunk/cmake/caches/Debug.cmake (added)
>> +++ test-suite/trunk/cmake/caches/Debug.cmake Thu Mar 10 19:26:06 2016
>> @@ -0,0 +1,2 @@
>> +set(CMAKE_C_FLAGS "-O0 -g" CACHE STRING "")
>> +set(CMAKE_CXX_FLAGS "-O0 -g" CACHE STRING "")
> 
> It probably makes more sense to set CMAKE_{C,CXX}_FLAGS_DEBUG and then
> set CMAKE_BUILD_TYPE=Debug here. That'll leave CMAKE_{C,CXX}_FLAGS open
> if you want to pass non-optimization flags for some other reason.
> 
> 
>> Added: test-suite/trunk/cmake/caches/Release.cmake
>> URL: http://llvm.org/viewvc/llvm-project/test-suite/trunk/cmake/caches/Release.cmake?rev=263182&view=auto
>> ==============================================================================
>> --- test-suite/trunk/cmake/caches/Release.cmake (added)
>> +++ test-suite/trunk/cmake/caches/Release.cmake Thu Mar 10 19:26:06 2016
>> @@ -0,0 +1,2 @@
>> +set(CMAKE_C_FLAGS "-O3 -flto" CACHE STRING "")
>> +set(CMAKE_CXX_FLAGS "-O3 -flto" CACHE STRING "")
> 
> Similarly, I'd just set CMAKE_BUILD_TYPE=Release and LLVM_ENABLE_LTO=On
> here - the CMAKE_{C,CXX}_FLAGS_RELEASE already do -O3.
> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits