[PATCH] D18085: [ELF] - Change all messages to be lowercase to be consistent.

[Rafael Espíndola via llvm-commits]

Gah, this basically reverted my patch.

On 11 March 2016 at 13:25, Rui Ueyama <ruiu at google.com> wrote:
> ruiu added inline comments.
>
> ================
> Comment at: lld/trunk/ELF/InputFiles.cpp:439-465
> @@ -482,16 +438,29 @@
>
>  void BitcodeFile::parse(DenseSet<StringRef> &ComdatGroups) {
>    LLVMContext Context;
>    std::unique_ptr<IRObjectFile> Obj = check(IRObjectFile::create(MB, Context));
>    const Module &M = Obj->getModule();
>
>    DenseSet<const Comdat *> KeptComdats;
>    for (const auto &P : M.getComdatSymbolTable()) {
>      StringRef N = Saver.save(P.first());
>      if (ComdatGroups.insert(N).second)
>        KeptComdats.insert(&P.second);
>    }
>
> -  for (const BasicSymbolRef &Sym : Obj->symbols())
> -    if (!shouldSkip(Sym))
> -      SymbolBodies.push_back(createSymbolBody(KeptComdats, *Obj, Sym));
> +  for (const BasicSymbolRef &Sym : Obj->symbols()) {
> +    const GlobalValue *GV = Obj->getSymbolGV(Sym.getRawDataRefImpl());
> +    assert(GV);
> +    uint32_t Flags = Sym.getFlags();
> +    if (const Comdat *C = GV->getComdat())
> +      if (!KeptComdats.count(C))
> +        continue;
> +    if (!(Flags & BasicSymbolRef::SF_Global))
> +        continue;
> +    if (GV->hasAppendingLinkage()) {
> +      ExtraKeeps.push_back(GV->getName().copy(Alloc));
> +      continue;
> +    }
> +    if (Flags & BasicSymbolRef::SF_FormatSpecific)
> +      continue;
> +    uint8_t Visibility = getGvVisibility(GV);
> ----------------
> Isn't this an accidental change?
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D18085
>
>
>