[PATCH] D18077: Factor out MachineBlockPlacement::fillWorkLists. NFC

Chad Rosier via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 11 12:23:24 PST 2016


mcrosier added inline comments.

================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:593
@@ +592,3 @@
+      if (BlockToChain[Pred] == &Chain)
+        continue;
+      ++Chain.UnscheduledPredecessors;
----------------
Perhaps it would be a good idea to add such a test case.

================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:598
@@ +597,3 @@
+
+  if (Chain.UnscheduledPredecessors != 0)
+    return;
----------------
Was this style suggested in D17625?


http://reviews.llvm.org/D18077





More information about the llvm-commits mailing list