[llvm] r263286 - [MemorySSA] Make a return type reflect reality. NFC.
George Burgess IV via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 11 11:34:04 PST 2016
Author: gbiv
Date: Fri Mar 11 13:34:03 2016
New Revision: 263286
URL: http://llvm.org/viewvc/llvm-project?rev=263286&view=rev
Log:
[MemorySSA] Make a return type reflect reality. NFC.
Modified:
llvm/trunk/include/llvm/Transforms/Utils/MemorySSA.h
llvm/trunk/lib/Transforms/Utils/MemorySSA.cpp
Modified: llvm/trunk/include/llvm/Transforms/Utils/MemorySSA.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Transforms/Utils/MemorySSA.h?rev=263286&r1=263285&r2=263286&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Transforms/Utils/MemorySSA.h (original)
+++ llvm/trunk/include/llvm/Transforms/Utils/MemorySSA.h Fri Mar 11 13:34:03 2016
@@ -553,7 +553,7 @@ private:
void computeDomLevels(DenseMap<DomTreeNode *, unsigned> &DomLevels);
void markUnreachableAsLiveOnEntry(BasicBlock *BB);
bool dominatesUse(const MemoryAccess *, const MemoryAccess *) const;
- MemoryAccess *createNewAccess(Instruction *, bool ignoreNonMemory = false);
+ MemoryUseOrDef *createNewAccess(Instruction *, bool ignoreNonMemory = false);
MemoryAccess *findDominatingDef(BasicBlock *, enum InsertionPlace);
void removeFromLookups(MemoryAccess *);
Modified: llvm/trunk/lib/Transforms/Utils/MemorySSA.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/MemorySSA.cpp?rev=263286&r1=263285&r2=263286&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Utils/MemorySSA.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/MemorySSA.cpp Fri Mar 11 13:34:03 2016
@@ -257,17 +257,17 @@ MemorySSAWalker *MemorySSA::buildMemoryS
bool InsertIntoDef = false;
AccessListType *Accesses = nullptr;
for (Instruction &I : B) {
- MemoryAccess *MA = createNewAccess(&I, true);
- if (!MA)
+ MemoryUseOrDef *MUD = createNewAccess(&I, true);
+ if (!MUD)
continue;
- if (isa<MemoryDef>(MA))
+ if (isa<MemoryDef>(MUD))
InsertIntoDef = true;
- else if (isa<MemoryUse>(MA))
+ else
InsertIntoDefUse = true;
if (!Accesses)
Accesses = getOrCreateAccessList(&B);
- Accesses->push_back(MA);
+ Accesses->push_back(MUD);
}
if (InsertIntoDef)
DefiningBlocks.insert(&B);
@@ -358,7 +358,8 @@ MemorySSAWalker *MemorySSA::buildMemoryS
}
/// \brief Helper function to create new memory accesses
-MemoryAccess *MemorySSA::createNewAccess(Instruction *I, bool IgnoreNonMemory) {
+MemoryUseOrDef *MemorySSA::createNewAccess(Instruction *I,
+ bool IgnoreNonMemory) {
// Find out what affect this instruction has on memory.
ModRefInfo ModRef = AA->getModRefInfo(I);
bool Def = bool(ModRef & MRI_Mod);
@@ -372,13 +373,13 @@ MemoryAccess *MemorySSA::createNewAccess
assert((Def || Use) &&
"Trying to create a memory access with a non-memory instruction");
- MemoryUseOrDef *MA;
+ MemoryUseOrDef *MUD;
if (Def)
- MA = new MemoryDef(I->getContext(), nullptr, I, I->getParent(), NextID++);
+ MUD = new MemoryDef(I->getContext(), nullptr, I, I->getParent(), NextID++);
else
- MA = new MemoryUse(I->getContext(), nullptr, I, I->getParent());
- ValueToMemoryAccess.insert(std::make_pair(I, MA));
- return MA;
+ MUD = new MemoryUse(I->getContext(), nullptr, I, I->getParent());
+ ValueToMemoryAccess.insert(std::make_pair(I, MUD));
+ return MUD;
}
MemoryAccess *MemorySSA::findDominatingDef(BasicBlock *UseBlock,
More information about the llvm-commits
mailing list