[PATCH] D18019: [PM] Port GVN to the new pass manager, wire it up, and teach a couple of tests to run GVN in both modes.
David Li via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 11 09:59:33 PST 2016
davidxl added inline comments.
================
Comment at: llvm/trunk/lib/Target/NVPTX/NVPTXTargetMachine.cpp:47
@@ -46,2 +46,3 @@
#include "llvm/Transforms/Scalar.h"
+#include "llvm/Transforms/Scalar/GVN.h"
----------------
chandlerc wrote:
> davidxl wrote:
> > I noticed this line -- why is this inclusion needed?
> Because NVPTX adds GVN into its target-specific code generation pass pipeline, and so it needs the 'createGVNPass' function. (You should be able to delete this and see the compile fail. At least, that's how I knew to add it.)
The question is why Scalar .h does not include GVN.h?
Repository:
rL LLVM
http://reviews.llvm.org/D18019
More information about the llvm-commits
mailing list