[PATCH] D18083: [ELF] - Refactor of InputSectionBase<ELFT>::relocate()
Simon Atanasyan via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 11 06:19:27 PST 2016
atanasyan added a subscriber: atanasyan.
================
Comment at: ELF/InputSection.cpp:186
@@ +185,3 @@
+ // the relocation's result for local symbol: S + A + GP0 - G.
+ SymVA += File->getMipsGp0();
+ return nullptr;
----------------
It is rather unexpected that function named `getLocalPaired` under some conditions do not find the pair but still change SymVA for relocations that never have pairs.
================
Comment at: ELF/InputSection.cpp:205
@@ +204,3 @@
+ SymVA = Out<ELFT>::Got->getMipsLocalPageAddr(SymVA + AHL);
+ return nullptr;
+}
----------------
Ditto
http://reviews.llvm.org/D18083
More information about the llvm-commits
mailing list