[PATCH] D18077: Factor out MachineBlockPlacement::fillWorkLists. NFC

[Chad Rosier via llvm-commits]

mcrosier added a subscriber: mcrosier.

================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:591
@@ +590,3 @@
+      if (BlockFilter && !BlockFilter->count(Pred))
+        return;
+      if (BlockToChain[Pred] == &Chain)
----------------
Should this be a continue?

================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:593
@@ +592,3 @@
+      if (BlockToChain[Pred] == &Chain)
+        return;
+      ++Chain.UnscheduledPredecessors;
----------------
Same as above. continue?

================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:598
@@ +597,3 @@
+
+  if (Chain.UnscheduledPredecessors != 0)
+    return;
----------------
If you don't mind, I'd prefer to stick with the style of the original code.

    if (Chain.UnscheduledPredecessors == 0)
      BlockWorkList.push_back(*Chain.begin());



http://reviews.llvm.org/D18077