[PATCH] D18056: Compute value of local symbol with getVA.
Rafael EspĂndola via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 11 04:21:32 PST 2016
On 10 March 2016 at 22:15, Rui Ueyama <ruiu at google.com> wrote:
> ruiu added inline comments.
>
> ================
> Comment at: ELF/Symbols.cpp:33
> @@ +32,3 @@
> +static typename ELFFile<ELFT>::uintX_t
> +getSymVA(const SymbolBody &Body, typename ELFFile<ELFT>::uintX_t &Addend) {
> + typedef typename ELFFile<ELFT>::Elf_Sym Elf_Sym;
> ----------------
> I think it makes more sense to keep it as a member function of SymbolBody.
It is a member function. It is just that now it has an static helper.
Cheers,
Rafael
More information about the llvm-commits
mailing list