[PATCH] D18022: Do not specialize IRBuilder to strip names in SROA

[Chandler Carruth via llvm-commits]

chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

LGTM patch is fine, but also see comment below.


================
Comment at: lib/Transforms/Scalar/SROA.cpp:93-104
@@ -95,5 +92,14 @@
+class IRBuilderPrefixedInserter : public IRBuilderDefaultInserter<true> {
+#ifndef NDEBUG
   std::string Prefix;
+  const Twine getNameWithPrefix(const Twine &Name) const {
+    return Name.isTriviallyEmpty() ? Name : Prefix + Name;
+  }
 
 public:
   void SetNamePrefix(const Twine &P) { Prefix = P.str(); }
+#else
+  const Twine getNameWithPrefix(const Twine &Name) const { return Name; }
+  void SetNamePrefix(const Twine &P) {}
+#endif
 
----------------
When you measured, did you measure getting rid of this complexity too?

If it doesn't slow SROA down when the context has the flag set, I would be all in favor of just completely removing the NDEBUG hacking here. My expectation is that the overhead of this while not zero (it uses an actual std::string) is *very* close to zero.

That said, if you'd rather submit as-is, I can take care of cleaning this up.


http://reviews.llvm.org/D18022