[PATCH] D18043: Remember the input section of locals

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 10 17:51:30 PST 2016


On Mar 10, 2016 6:30 PM, "Rui Ueyama" <ruiu at google.com> wrote:
>
> ruiu added inline comments.
>
> ================
> Comment at: ELF/OutputSections.cpp:272-277
> @@ +271,8 @@
> +        if (auto *L = dyn_cast<LocalSymbol<ELFT>>(Sym)) {
> +          uintX_t Pos = L->Sym.st_value;
> +          if (L->Sym.getType() == STT_SECTION) {
> +            Pos += Addend;
> +            Addend = 0;
> +          }
> +          VA = L->Section->OutSec->getVA() + L->Section->getOffset(Pos);
> +        } else {
> ----------------
> Can't you move this to getVA for LocalSymbol?
>
>

That is what the next patch does:
http://reviews.llvm.org/D18056
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160310/605439e2/attachment.html>


More information about the llvm-commits mailing list