[PATCH] D17792: Initialize much of AssemblyWriter lazily.
Justin Lebar via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 10 14:08:05 PST 2016
jlebar added inline comments.
================
Comment at: lib/IR/AsmWriter.cpp:424
@@ +423,3 @@
+ /// The named types that are used by the current module.
+ auto GetNamedTypes() -> decltype(*LazyNamedTypes) {
+ EnsureTypesInitialized();
----------------
rafael wrote:
> Why the fancy decltype? Can this be just
>
> TypeFinder getNamedTypes() {....
>
> ?
>
I have no idea why I did that. If I should use the fancy thing anywhere, it should be on the function below, which at least has an ugly return type.
Anyway, fixed, thank you.
http://reviews.llvm.org/D17792
More information about the llvm-commits
mailing list