[PATCH] D17781: Codegen: [PPC] Word Rotates are Zero Extending

Kit Barton via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 10 12:15:17 PST 2016


kbarton added inline comments.

================
Comment at: lib/Target/PowerPC/PPCInstrInfo.cpp:1559
@@ +1558,3 @@
+  bool isZeroExtendingRotate  =
+      (MIOpC == PPC::RLWINM || MIOpC == PPC::RLWNM)
+      && MI->getOperand(3).getImm() <= MI->getOperand(4).getImm();
----------------
iteratee wrote:
> I actually meant to use PPC::RLWNM.
> I added a test case to cover this.
OK, this might be a dumb question then but why not include the dot version of the instructions (RLWINMo and RLWNMo) as well?


http://reviews.llvm.org/D17781





More information about the llvm-commits mailing list