[lld] r263125 - [ELF] - Consistent spelling for error/warning messages

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 10 10:35:29 PST 2016


I prefer starting with lowercase characters because it is consistent with
clang and it makes it easy to concatenate error strings. I mean

  foo.obj: error: invalid relocation: relocation type (42) is unknown

looks better than

  foo.obj: Error: Invalid relocation: Relocation type (42) is unknown

(assuming that each string piece is created separately.)

On Thu, Mar 10, 2016 at 10:31 AM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> .
> >
> > Rui, Rafael what do you think ? I can prepare the patch for that.
>
> I personally just care about it being consistent. So OK with lowercase if
> others have that preference.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160310/1f1c1cc1/attachment.html>


More information about the llvm-commits mailing list