[PATCH] D18041: [ELF] use fatal() instead of llvm_unreachable when performing relaxations.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 10 10:12:11 PST 2016


On 10 March 2016 at 13:05, George Rimar <grimar at accesssoftek.com> wrote:
>>>Is that optimized away in a Release build?
>>
>>It can be and can be not I think. Not good solution it seems, but at least can help with debug build.
>>
>>>Cheers,
>>>Rafael
>
> Why not to use fatal() then ? It seems to fit the needs.


Because fatal is for *errors*, not *bugs*.

You can propose passing a twine to llvm_unreachable if you think it is
really worth it.

Cheers,
Rafael


More information about the llvm-commits mailing list