[llvm] r263110 - [CG] Try adding an explicit move constructor to see if that helps the

[David Blaikie via llvm-commits]

Ah, I see, addressed in 263114 - thanks!

On Thu, Mar 10, 2016 at 10:07 AM, David Blaikie <dblaikie at gmail.com> wrote:

>
>
> On Thu, Mar 10, 2016 at 5:43 AM, Chandler Carruth via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> Author: chandlerc
>> Date: Thu Mar 10 07:43:06 2016
>> New Revision: 263110
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=263110&view=rev
>> Log:
>> [CG] Try adding an explicit move constructor to see if that helps the
>> one build bot that is crashing on this code.
>>
>> Modified:
>>     llvm/trunk/include/llvm/Analysis/CallGraph.h
>>
>> Modified: llvm/trunk/include/llvm/Analysis/CallGraph.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/CallGraph.h?rev=263110&r1=263109&r2=263110&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/include/llvm/Analysis/CallGraph.h (original)
>> +++ llvm/trunk/include/llvm/Analysis/CallGraph.h Thu Mar 10 07:43:06 2016
>> @@ -312,6 +312,7 @@ class CallGraphPrinterPass : public Pass
>>
>>  public:
>>    explicit CallGraphPrinterPass(raw_ostream &OS) : OS(OS) {}
>> +  CallGraphPrinterPass(CallGraphPrinterPass &&Arg) : OS(Arg.OS) {}
>>
>
> This move ctor looks conspicuously like a copy ctor (apart from the
> parameter type) - what's the deal? (or maybe this type has other members
> that aren't being copied, that makes this more move-like - I haven't
> checked the header to see what its actual member list is)
>
> Did this end up working? If so, any idea why?
>
>
>>    PreservedAnalyses run(Module &M, AnalysisManager<Module> *AM);
>>  };
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160310/f376a9a0/attachment.html>