[PATCH] D18039: [ELF] - Fixed handling R_X86_64_DTPOFF64 relocation relaxation

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 10 09:45:07 PST 2016


ruiu added inline comments.

================
Comment at: ELF/Target.cpp:958-963
@@ -954,2 +957,8 @@
   }
+  case R_X86_64_TPOFF64: {
+    uint64_t Val = SA - Out<ELF64LE>::TlsPhdr->p_memsz;
+    checkInt<64>(Val, Type);
+    write64le(Loc, Val);
+    break;
+  }
   default:
----------------
Can't you reach this piece of code without going through relaxTls, can you?

If that's the case, please move this piece of code to relaxTls.


http://reviews.llvm.org/D18039





More information about the llvm-commits mailing list