[llvm] r263086 - Add a flag to the LLVMContext to disable name for Value other than GlobalValue

[Mehdi Amini via llvm-commits]

Should be fixed with r263127.

Let me know if it is not enough.

-- 
Mehdi

> On Mar 10, 2016, at 8:21 AM, Mehdi Amini <mehdi.amini at apple.com> wrote:
> 
> Hi Michel,
> 
>> On Mar 10, 2016, at 12:31 AM, Michel Dänzer <michel at daenzer.net> wrote:
>> 
>> 
>> Hi Mehdi,
>> 
>> 
>> On 10.03.2016 10:28, Mehdi Amini via llvm-commits wrote:
>>> Author: mehdi_amini
>>> Date: Wed Mar  9 19:28:54 2016
>>> New Revision: 263086
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=263086&view=rev
>>> Log:
>>> Add a flag to the LLVMContext to disable name for Value other than GlobalValue
>> 
>> This change broke thousands of lit tests for me. Here's an example:
> 
> Sorry about that, I'll fix ASAP.
> 
>> 
>> FAIL: LLVM :: Analysis/BasicAA/2003-04-22-GEPProblem.ll (1 of 16028)
>> ******************** TEST 'LLVM :: Analysis/BasicAA/2003-04-22-GEPProblem.ll' FAILED ********************
>> Script:
>> --
>> /home/daenzer/src/llvm-git/llvm/build-amd64/./bin/opt < /home/daenzer/src/llvm-git/llvm/test/Analysis/BasicAA/2003-04-22-GEPProblem.ll -basicaa -gvn -instcombine -S | /home/daenzer/src/llvm-git/llvm/build-amd64/./bin/FileCheck /home/daenzer/src/llvm-git/llvm/test/Analysis/BasicAA/2003-04-22-GEPProblem.ll
>> --
>> Exit Code: 2
>> 
>> Command Output (stderr):
>> --
>> : CommandLine Error: Option 'discard-value-names' registered more than once!
>> LLVM ERROR: inconsistency in registered CommandLine options
>> FileCheck error: '-' is empty.
>> 
>> 
>> My CMake options are:
>> 
>> -G Ninja -DCMAKE_BUILD_TYPE=RelWithDebInfo -DLLVM_TARGETS_TO_BUILD="X86;AMDGPU" -DCLANG_ENABLE_ARCMT=OFF -DCLANG_ENABLE_STATIC_ANALYZER=OFF -DWITH_POLLY=OFF -DCMAKE_CXX_COMPILER=/usr/lib/ccache/g++ -DCMAKE_CXX_FLAGS_RELWITHDEBINFO="-O2 -g -DNDEBUG -fno-omit-frame-pointer -ftree-vectorize -march=amdfam10 -mtune=native" -DCMAKE_C_FLAGS_RELWITHDEBINFO="-O2 -g -DNDEBUG -fno-omit-frame-pointer -ftree-vectorize -march=amdfam10 -mtune=native" -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_BUILD_LLVM_DYLIB=ON -DLLVM_LINK_LLVM_DYLIB=ON -DLLVM_DISABLE_LLVM_DYLIB_ATEXIT=OFF -DLLVM_TOOL_LTO_BUILD=OFF
> 
> I guess that this config is with one single llvm.so library right?
> It is probably linking libLTO inside, which make it linked with opt.
> My assumptions was that opt does not link to libLTO, but this use case obviously breaks my assumption.
> I should be able to provide a fix soon.
> 
> Best,
> 
> Mehdi