[PATCH] D18047: [ELF] - Do not call doInitSymbols for all ELFTs

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 10 09:11:58 PST 2016


On 10 March 2016 at 12:06, George Rimar <grimar at accesssoftek.com> wrote:
> grimar added a comment.
>
> In http://reviews.llvm.org/D18047#371990, @grimar wrote:
>
>> In http://reviews.llvm.org/D18047#371986, @rafael wrote:
>>
>> > LGTM. As a followup patch, can you move doInitSymbols to Driver.cpp and make it static?
>>
>>
>> Sure. Should this change also be reviewed or can I just commit it after this one ?
>
>
> I mean "followup" here is the same commit or separate one ?

separate one is probably better.

Thanks,
Rafael


More information about the llvm-commits mailing list