[PATCH] D18004: [ELF] - refactor of SymbolBody::compare()

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 10 09:00:18 PST 2016


grimar added inline comments.

================
Comment at: ELF/Symbols.cpp:117
@@ +116,3 @@
+  if (A->Size < B->Size) {
+    B->MaxAlignment = std::max(A->MaxAlignment, B->MaxAlignment);
+    return -1;
----------------
rafael wrote:
> I think you can just say
> 
> A->MaxAlingment = B->MaxAlignment = std::max(A->MaxAlignment, B->MaxAlignment);
> 
> before the if.
Sounds good for me.


http://reviews.llvm.org/D18004





More information about the llvm-commits mailing list