[PATCH] D16998: [AMDGPU] llvm-objdump: disassembling .hsatext section of HSA Code Object v1.0

[Valery Pykhtin via llvm-commits]

vpykhtin added a comment.

In http://reviews.llvm.org/D16998#371942, @rafael wrote:

> How has the test created. What is a ".co"?


".co" means CodeObject. It was created using out of llvm tree utility. It is of HSA Code Object v1.0 format which is slightly different from what AMDGPU assembler currently emitting, the main difference is - code symbol has zero size and amd_kernel_code_t (runtime control structure) and ISA could be non-adjacent. The dissasembler is supposed to accept both versions.


================
Comment at: lib/Target/AMDGPU/Disassembler/HSAObjCodeDisassembler.cpp:113
@@ +112,3 @@
+
+class OwningMCContext : MCContext {
+  std::unique_ptr<const MCRegisterInfo> MRI;
----------------
vpykhtin wrote:
> arsenm wrote:
> > Would this be useful in the MCContext header?
> Yep, I would move it there.
Let's do it in separate change later.


http://reviews.llvm.org/D16998