[PATCH] D18026: [lld] [ELF/AArch64] Fix TLS IE to LE relax for local symbols

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: test/ELF/aarch64-tls-iele.s:17
@@ +16,3 @@
+#CHECK:  11004:	80 02 80 f2     movk    x0, #0x14
+#CHECK:  11008: 00 00 a0 d2     movz    x0, #0, lsl #16
+#CHECK:  1100c: 00 02 80 f2     movk    x0, #0x10
----------------
Please align accordinly, remove space after ':'

```
11000: 00 00 a0 d2     movz    x0, #0, lsl #16
11004: 80 02 80 f2     movk    x0, #0x14
11008: 00 00 a0 d2     movz    x0, #0, lsl #16
```

Second is that you probably want to use "CHECK-NEXT":

```
# CHECK:            11000:  00 00 a0 d2     movz    x0, #0, lsl #16
# CHECK-NEXT:  11004:  80 02 80 f2      movk    x0, #0x14
# CHECK-NEXT:  11008:  00 00 a0 d2     movz    x0, #0, lsl #16

```
And the last is that this testcase contains different spacing style:
"# RUN" vs "#CHECK" for example. Please choose one style to follow in a single test. That probably should be fixed separatelly.



Repository:
  rL LLVM

http://reviews.llvm.org/D18026