[PATCH] D17925: [ARM] Add Cortex-R8 to target parser and tablegen

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 9 21:41:26 PST 2016


t.p.northover added inline comments.

================
Comment at: lib/Target/ARM/ARM.td:637
@@ +636,3 @@
+                                                         FeatureSlowFPBrcc,
+                                                         FeatureHWDivARM,
+                                                         FeatureHasSlowFPVMLx,
----------------
rengolin wrote:
> R6+ supports HWDIV for both ARM and Thumb.
Good catch. In a possibly related note, what's happening with MCHammer within ARM? 

This seems like exactly the sort of issue it should have caught (an encoding that was invalid on LLVM but should have been supported).

Abandoning it is obviously fine (it was internal anyway), but I'd sort of been assuming that patches from ARM were backed by that kind of verification (which at least included 2 mostly independent implementations of the same instruction).


http://reviews.llvm.org/D17925





More information about the llvm-commits mailing list