[PATCH] D18010: AMDGPU: R600 code splitting cleanup

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 9 18:11:12 PST 2016


On 03/09/2016 05:21 PM, David Blaikie wrote:
> What's the reason for marking the classes final? We don't usually go 
> out of our way to do that, except for -Wnon-virtual-dtor silencing (in 
> my experience/practice) - so perhaps it's that case? (just not clear 
> to me from the commit/code (without going & looking at the 
> hierarchies, etc)
Because they can be. There's no reason to further subclass these, and 
might as well allow the compiler to emit direct calls to them.

-Matt


More information about the llvm-commits mailing list