[PATCH] D18013: Using MPI for Profiling Data Reduction

David Li via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 9 17:20:31 PST 2016


davidxl added inline comments.

================
Comment at: lib/profile/InstrProfilingReduce.c:30
@@ +29,3 @@
+              0, MPI_COMM_WORLD);
+   return PMPI_Finalize();
+}
----------------
hfinkel wrote:
> davidxl wrote:
> > Should return be used for Rank !=0 cases too?
> It is used in both cases, however this is not visually obvious because the else statement has no braces.
> 
> Please add braces around the else body (for consistency with the if body).
Right -- my eyes certainly fooled me in this case.


http://reviews.llvm.org/D18013





More information about the llvm-commits mailing list