[PATCH] D18013: Using MPI for Profiling Data Reduction

[Sean Silva via llvm-commits]

silvas added a subscriber: silvas.

================
Comment at: lib/profile/InstrProfilingFile.c:86
@@ -74,2 +85,3 @@
   const char *Filename;
+#ifdef _MSC_VER
   FILE *File;
----------------
Let's split this change into a separate patch for a focused discussion on the requirements and possible solutions.

================
Comment at: lib/profile/InstrProfilingReduce.c:1
@@ +1,2 @@
+/*===- InstrProfilingReduce.c - Support library for applications using MPI ===*\
+|*
----------------
Let's call this InstrProfilingMPI.c consistent with the comment.

================
Comment at: lib/profile/InstrProfilingStub.c:14
@@ +13,2 @@
+void MPI_Reduce() { abort(); }
+void PMPI_Finalize() { abort(); }
----------------
davidxl wrote:
> Is the MPI library defining thse functions  static or a DSO? If the former, then perhaps declare those stubs weak so that we don't rely on the link order of the runtime library
Why do we need these stubs?


http://reviews.llvm.org/D18013