[PATCH] D18012: [lto] Make sure that ctors are added to the combined module.

Sean Silva via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 9 15:21:10 PST 2016


silvas added inline comments.

================
Comment at: ELF/InputFiles.cpp:454
@@ -454,1 +453,3 @@
+    if (Flags & BasicSymbolRef::SF_FormatSpecific) {
+      ExtraKeeps.push_back(GV->getName().copy(Alloc));
       continue;
----------------
ruiu wrote:
> Do you need to copy strings? Because Symtab has unique_ptrs to BitcodeFiles, they are not freed until the program ends.
Yes. `M` goes away at the end of this function.


http://reviews.llvm.org/D18012





More information about the llvm-commits mailing list