[PATCH] D18004: [ELF] - refactor of SymbolBody::compare()

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/Symbols.cpp:119
@@ -118,3 +125,2 @@
-  typedef typename ELFFile<ELFT>::uintX_t uintX_t;
   assert(!isLazy() && !Other->isLazy());
   std::tuple<bool, bool, bool> L(isDefined(), !isShared(), !isWeak());
----------------
btw we anyways don't need that as ThisC->MaxAlignment/OtherC->MaxAlignment are of a type uint64

================
Comment at: ELF/Symbols.cpp:124
@@ -116,4 +123,3 @@
 // over the Other, tie or lose, respectively.
 template <class ELFT> int SymbolBody::compare(SymbolBody *Other) {
   assert(!isLazy() && !Other->isLazy());
----------------
btw, I think it requires a new name. It does not just compares bodies, but also set flags, so do not what its name says.
I dont have good suggestions about name, may be resolveBody ?


http://reviews.llvm.org/D18004