[PATCH] D17918: [ELF] - Issue an error if trying to link object that uses splitstacks.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/InputFiles.cpp:179
@@ -178,1 +178,3 @@
+    if (HasError)
+      return;
     ++I;
----------------
grimar wrote:
> That's not actually needed for this patch to work, but it seems reasonable to have ?
I wouldn't add it.

================
Comment at: ELF/InputFiles.cpp:250
@@ -247,1 +249,3 @@
 
+  // .note.GNU-split-stack is a marker we don't support currently.
+  if (Name == ".note.GNU-split-stack")
----------------
I don't think this comment describes anything beyond what the code does, so please remove it.

================
Comment at: test/ELF/splitstacks.s:5-6
@@ +4,4 @@
+## Check that splitstacks objects are not allowed.
+# RUN: not ld.lld %t1.o -o %t 2>&1 | \
+# RUN:    FileCheck --check-prefix=ERR %s
+# ERR: Objects using splitstacks are not supported
----------------
You can write in one line. Remove --check-prefix=ERR.

================
Comment at: test/ELF/splitstacks.s:7
@@ +6,3 @@
+# RUN:    FileCheck --check-prefix=ERR %s
+# ERR: Objects using splitstacks are not supported
+
----------------
ERR -> CHECK


http://reviews.llvm.org/D17918