[PATCH] D17098: [AArch64] analyse dependences of ldp/stp

Chad Rosier via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 8 19:22:37 PST 2016


mcrosier added a comment.

In http://reviews.llvm.org/D17098#370320, @sebpop wrote:

> In http://reviews.llvm.org/D17098#370005, @mcrosier wrote:
>
> > Correct scale/offset issues and address all previous feedback.
>
>
> The corrected version looks very similar to what I remember having implemented first, and then we found out that the scale did not match.
>  Let's not apply this patch yet: I need to discuss this again with my colleague Abderrazek and we will try to find why we changed to scale = width for ldp/stp formation.  We will come back with a counter-example if we find one.


Sounds good.  Let me know if I've missed something. The matching scale and offsets caused a large number of correctness failures in the test-suite as well as SPEC200X in my testing.


http://reviews.llvm.org/D17098





More information about the llvm-commits mailing list