[PATCH] D17967: [TII] Allow getMemOpBaseRegImmOfs() to accept negative offsets. NFC.

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 8 14:06:20 PST 2016


arsenm added inline comments.

================
Comment at: include/llvm/Target/TargetInstrInfo.h:976
@@ -975,3 +975,3 @@
   virtual bool getMemOpBaseRegImmOfs(MachineInstr *MemOp, unsigned &BaseReg,
-                                     unsigned &Offset,
+                                     int &Offset,
                                      const TargetRegisterInfo *TRI) const {
----------------
I think this should be changed to int64_t to be consistent with other offsets everywhere else


http://reviews.llvm.org/D17967





More information about the llvm-commits mailing list