[PATCH] D16381: Infrastructure to allow use of PGO in inliner

[Daniel Berlin via llvm-commits]

On Tue, Mar 8, 2016 at 10:41 AM, Xinliang David Li via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

>
>
> On Tue, Mar 8, 2016 at 4:20 AM, Chandler Carruth <chandlerc at gmail.com>
> wrote:
>
>> chandlerc added a comment.
>>
>> First and foremost, sorry about snapping earlier. I shouldn't have done
>> that, I was frustrated and not communicating very effectively. Thanks to
>> Sean and Hal and others who wrote constructive and helpful emails to get
>> this back on the rails. Secondly, sorry that I've neglected this patch for
>> so long. I kept prioritizing working on the actual pass manager stuff over
>> it, and I should have at least written this up.
>>
>
> Apology accepted. Chandler, as a long time contributor to LLVM project,
> new contributors will see you as an example to follow. I don't see the
> following match what people expect to see: Ignoring review requests,
> showing disagreement by keeping silence, implying people not respecting
> your authority in your area, or dictating who can/can not do this or that.
> Reviews takes a lot of time and energy so you should encourage more people
> participate in it by helping people gain more experience and feel more
> confident to approve and get things done.   In this particular case, if you
> had raised any concerns in the long thread, the approval would have *not*
> been given without consensus being made. Even after the commit, if you had
> listed any concrete reasons why the patch should be reverted first for
> further discussion, it would have been done without a blink, but you came
> out with a blame first, followed by a strong demand with no reason (as if
> this is my domain ....)
>
>
(I will say this publicly because everything else has been done publicly at
this point :P)

Guys.
I understand you are both frustrated at each other and the state of this
review (and probably others)
But i don't think either of you are making useful responses to each other
at this point.
It just comes off as sniping, even if it's not meant to.

I would suggest that we take this offline and have a chat.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160308/0738b8a9/attachment.html>