[PATCH] D16481: Split PrologEpilogInserter into 2 parts

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 8 09:53:20 PST 2016


qcolombet added a comment.

Hi Derek,

I am behind on reviews and I am still fighting to catching up.
I have one high level comment though, see the inlined comment.

Cheers,
-Quentin


================
Comment at: lib/CodeGen/PrologEpilogInserter.cpp:77
@@ +76,3 @@
+  // replacement sometimes depends on it.
+  RegScavenger *RS = nullptr;
+
----------------
It feels wrong to me that the high level class needs to have this field.


http://reviews.llvm.org/D16481





More information about the llvm-commits mailing list