[PATCH] D17098: [AArch64] analyse dependences of ldp/stp

[Chad Rosier via llvm-commits]

mcrosier requested changes to this revision.
mcrosier added a comment.
This revision now requires changes to proceed.

I wanted to push this patch along, so I ran some correctness tests.  It turns out the paired instructions aren't being scaled properly (see inline comments).  After addressing those issues I'm now seeing a few regressions due to fewer stp instructions.  I'm going to block this patch while I investigate.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1405
@@ +1404,3 @@
+  case AArch64::STNPQi:
+    Scale = Width = 32;
+    break;
----------------
Scale = 16;
Width = 32;

================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1414
@@ -1395,1 +1413,3 @@
+  case AArch64::STNPXi:
+  case AArch64::STNPDi:
   case AArch64::LDRQui:
----------------
Scale = 8;
Width = 16;

================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1426
@@ -1399,1 +1425,3 @@
+  case AArch64::LDNPSi:
+  case AArch64::STNPSi:
   case AArch64::LDRXui:
----------------
Scale = 4;
Width = 8;


http://reviews.llvm.org/D17098