[PATCH] D17884: Disallow duplication of imported entities

Amjad Aboud via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 7 12:03:29 PST 2016


aaboud added a comment.

In http://reviews.llvm.org/D17884#369172, @dblaikie wrote:

> Pretty sure we shouldn't be adding things to LLVMContext for this, but I
>  haven't looked closely at the patch/followed the discussion that got us
>  there in the first place. Will come back to this when I get a chance
>  (probably later this week) but I'm mentioning it in case others
>  reading/interacting on the thread can figure it out before then.


Thanks David,
Please, when you have time to review this, check also patch 49934 (Diff 2).
It is a simpler solution, but not sure also that it is the right one.


http://reviews.llvm.org/D17884





More information about the llvm-commits mailing list