[PATCH] D17884: Disallow duplication of imported entities

[David Blaikie via llvm-commits]

Pretty sure we shouldn't be adding things to LLVMContext for this, but I
haven't looked closely at the patch/followed the discussion that got us
there in the first place. Will come back to this when I get a chance
(probably later this week) but I'm mentioning it in case others
reading/interacting on the thread can figure it out before then.

On Mon, Mar 7, 2016 at 9:18 AM, Amjad Aboud via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> aaboud updated this revision to Diff 49973.
> aaboud added a comment.
>
> Another try, this time I am uploading suggested solution by Don Hinton.
> He is suggesting to make "imports" field in DICompileUnit of new type
> "unique vector".
> Then we can get rid of AllImportedEntitys container and use directly the
> LLVMContext::impl::DIImportedEntitys instead
>
>
> http://reviews.llvm.org/D17884
>
> Files:
>   include/llvm/ADT/SetVector.h
>   include/llvm/IR/Metadata.def
>   lib/IR/DIBuilder.cpp
>   lib/IR/LLVMContextImpl.h
>   lib/IR/Metadata.cpp
>   lib/IR/MetadataImpl.h
>   unittests/IR/IRBuilderTest.cpp
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160307/78674ff3/attachment.html>