[lld] r262796 - [ELF] - Simplify a SymbolBody class interface a bit.
George Rimar via llvm-commits
llvm-commits at lists.llvm.org
Sat Mar 5 22:26:18 PST 2016
Author: grimar
Date: Sun Mar 6 00:26:18 2016
New Revision: 262796
URL: http://llvm.org/viewvc/llvm-project?rev=262796&view=rev
Log:
[ELF] - Simplify a SymbolBody class interface a bit.
Get rid of few accessors in that class, and replace
them with direct fields access.
Differential revision: http://reviews.llvm.org/D17879
Modified:
lld/trunk/ELF/InputSection.cpp
lld/trunk/ELF/OutputSections.cpp
lld/trunk/ELF/SymbolTable.cpp
lld/trunk/ELF/Symbols.cpp
lld/trunk/ELF/Symbols.h
lld/trunk/ELF/Target.cpp
lld/trunk/ELF/Writer.cpp
Modified: lld/trunk/ELF/InputSection.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputSection.cpp?rev=262796&r1=262795&r2=262796&view=diff
==============================================================================
--- lld/trunk/ELF/InputSection.cpp (original)
+++ lld/trunk/ELF/InputSection.cpp Sun Mar 6 00:26:18 2016
@@ -282,7 +282,7 @@ void InputSectionBase<ELFT>::relocate(ui
SymVA = Out<ELFT>::Got->getMipsLocalFullAddr(*Body);
else
SymVA = Body->getGotVA<ELFT>();
- if (Body->isTls())
+ if (Body->IsTls)
Type = Target->getTlsGotRel(Type);
} else if (!Target->needsCopyRel<ELFT>(Type, *Body) &&
isa<SharedSymbol<ELFT>>(*Body)) {
Modified: lld/trunk/ELF/OutputSections.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/OutputSections.cpp?rev=262796&r1=262795&r2=262796&view=diff
==============================================================================
--- lld/trunk/ELF/OutputSections.cpp (original)
+++ lld/trunk/ELF/OutputSections.cpp Sun Mar 6 00:26:18 2016
@@ -955,7 +955,7 @@ bool elf::canBePreempted(const SymbolBod
return false;
if (Body->getVisibility() != STV_DEFAULT)
return false;
- if (Config->Bsymbolic || (Config->BsymbolicFunctions && Body->isFunc()))
+ if (Config->Bsymbolic || (Config->BsymbolicFunctions && Body->IsFunc))
return false;
return true;
}
Modified: lld/trunk/ELF/SymbolTable.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/SymbolTable.cpp?rev=262796&r1=262795&r2=262796&view=diff
==============================================================================
--- lld/trunk/ELF/SymbolTable.cpp (original)
+++ lld/trunk/ELF/SymbolTable.cpp Sun Mar 6 00:26:18 2016
@@ -285,7 +285,7 @@ template <class ELFT> void SymbolTable<E
return;
}
- if (New->isTls() != Existing->isTls()) {
+ if (New->IsTls != Existing->IsTls) {
error("TLS attribute mismatch for symbol: " + conflictMsg(Existing, New));
return;
}
@@ -346,8 +346,7 @@ void SymbolTable<ELFT>::addMemberFile(Un
L->setWeak();
// FIXME: Do we need to copy more?
- if (Undef->isTls())
- L->setTls();
+ L->IsTls |= Undef->IsTls;
return;
}
Modified: lld/trunk/ELF/Symbols.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Symbols.cpp?rev=262796&r1=262795&r2=262796&view=diff
==============================================================================
--- lld/trunk/ELF/Symbols.cpp (original)
+++ lld/trunk/ELF/Symbols.cpp Sun Mar 6 00:26:18 2016
@@ -61,7 +61,7 @@ typename ELFFile<ELFT>::uintX_t SymbolBo
auto *SS = cast<SharedSymbol<ELFT>>(this);
if (!SS->NeedsCopyOrPltAddr)
return 0;
- if (SS->isFunc())
+ if (SS->IsFunc)
return getPltVA<ELFT>();
else
return Out<ELFT>::Bss->getVA() + SS->OffsetInBss;
Modified: lld/trunk/ELF/Symbols.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Symbols.h?rev=262796&r1=262795&r2=262796&view=diff
==============================================================================
--- lld/trunk/ELF/Symbols.h (original)
+++ lld/trunk/ELF/Symbols.h Sun Mar 6 00:26:18 2016
@@ -84,8 +84,6 @@ public:
bool isLazy() const { return SymbolKind == LazyKind; }
bool isShared() const { return SymbolKind == SharedKind; }
bool isUsedInRegularObj() const { return IsUsedInRegularObj; }
- bool isFunc() const { return Type == llvm::ELF::STT_FUNC; }
- bool isTls() const { return Type == llvm::ELF::STT_TLS; }
// Returns the symbol name.
StringRef getName() const { return Name; }
@@ -131,8 +129,9 @@ protected:
SymbolBody(Kind K, StringRef Name, bool IsWeak, uint8_t Visibility,
uint8_t Type)
: SymbolKind(K), IsWeak(IsWeak), Visibility(Visibility),
- MustBeInDynSym(false), NeedsCopyOrPltAddr(false),
- Type(Type), Name(Name) {
+ MustBeInDynSym(false), NeedsCopyOrPltAddr(false), Name(Name) {
+ IsFunc = Type == llvm::ELF::STT_FUNC;
+ IsTls = Type == llvm::ELF::STT_TLS;
IsUsedInRegularObj = K != SharedKind && K != LazyKind;
}
@@ -154,9 +153,10 @@ public:
// symbol or if the symbol should point to its plt entry.
unsigned NeedsCopyOrPltAddr : 1;
-protected:
- uint8_t Type;
+ unsigned IsTls : 1;
+ unsigned IsFunc : 1;
+protected:
StringRef Name;
Symbol *Backref = nullptr;
};
@@ -305,7 +305,7 @@ public:
// OffsetInBss is significant only when needsCopy() is true.
uintX_t OffsetInBss = 0;
- bool needsCopy() const { return this->NeedsCopyOrPltAddr && !this->isFunc(); }
+ bool needsCopy() const { return this->NeedsCopyOrPltAddr && !this->IsFunc; }
};
// This class represents a symbol defined in an archive file. It is
@@ -326,7 +326,6 @@ public:
// was already returned.
std::unique_ptr<InputFile> getMember();
- void setTls() { this->Type = llvm::ELF::STT_TLS; }
void setWeak() { IsWeak = true; }
void setUsedInRegularObj() { IsUsedInRegularObj = true; }
Modified: lld/trunk/ELF/Target.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Target.cpp?rev=262796&r1=262795&r2=262796&view=diff
==============================================================================
--- lld/trunk/ELF/Target.cpp (original)
+++ lld/trunk/ELF/Target.cpp Sun Mar 6 00:26:18 2016
@@ -264,7 +264,7 @@ TargetInfo *createTarget() {
TargetInfo::~TargetInfo() {}
bool TargetInfo::canRelaxTls(uint32_t Type, const SymbolBody *S) const {
- if (Config->Shared || (S && !S->isTls()))
+ if (Config->Shared || (S && !S->IsTls))
return false;
// We know we are producing an executable.
@@ -485,7 +485,7 @@ bool X86TargetInfo::needsCopyRelImpl(uin
}
bool X86TargetInfo::needsGot(uint32_t Type, SymbolBody &S) const {
- if (S.isTls() && Type == R_386_TLS_GD)
+ if (S.IsTls && Type == R_386_TLS_GD)
return Target->canRelaxTls(Type, &S) && canBePreempted(&S);
if (Type == R_386_TLS_GOTIE || Type == R_386_TLS_IE)
return !canRelaxTls(Type, &S);
Modified: lld/trunk/ELF/Writer.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=262796&r1=262795&r2=262796&view=diff
==============================================================================
--- lld/trunk/ELF/Writer.cpp (original)
+++ lld/trunk/ELF/Writer.cpp Sun Mar 6 00:26:18 2016
@@ -268,7 +268,7 @@ static bool handleTlsRelocation(uint32_t
return true;
}
- if (!Body || !Body->isTls())
+ if (!Body || !Body->IsTls)
return false;
if (Target->isTlsGlobalDynamicRel(Type)) {
@@ -424,7 +424,7 @@ void Writer<ELFT>::scanRelocs(
if (CBP || Dynrel) {
uint32_t DynType;
if (CBP)
- DynType = Body->isTls() ? Target->TlsGotRel : Target->GotRel;
+ DynType = Body->IsTls ? Target->TlsGotRel : Target->GotRel;
else
DynType = Target->RelativeRel;
Out<ELFT>::RelaDyn->addReloc(
More information about the llvm-commits
mailing list