[PATCH] D17884: Disallow duplication of imported entities

don hinton via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 5 06:32:31 PST 2016


hintonda added a subscriber: hintonda.

================
Comment at: lib/IR/DIBuilder.cpp:171
@@ -170,2 +170,3 @@
                      SmallVectorImpl<TrackingMDNodeRef> &AllImportedModules) {
   auto *M = DIImportedEntity::get(C, Tag, Context, DINodeRef(NS), Line, Name);
+  // Assure no duplications in AllImportedModules list.
----------------
Since these are maintained in a DenseMap in LLVMContextImpl, which is already unique, is there a way to use that directly instead of maintaining an additional vector?


http://reviews.llvm.org/D17884





More information about the llvm-commits mailing list