[PATCH] D17884: Disallow duplication of imported entities

Amjad Aboud via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 4 16:59:33 PST 2016


aaboud added a comment.

In http://reviews.llvm.org/D17884#368253, @aprantl wrote:

> That, or we make AllImportedUnits a SmallSet (which is arguably more expensive).


SmallSet is not good enough, as the order will be arbitrary and we will get non-deterministic order of imported entries that have same context.
I thought to use VectorSet, but it does not have the embrace_push function!


http://reviews.llvm.org/D17884





More information about the llvm-commits mailing list