[PATCH] D17900: [gold] Fix common symbols handling

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 4 16:32:21 PST 2016


eugenis created this revision.
eugenis added a reviewer: rafael.
eugenis added a subscriber: llvm-commits.
eugenis set the repository for this revision to rL LLVM.

LLVM Gold plugin decides which instance of a common symbol it wants
based on the symbol size in claim_file_hook. If the file that
contains the chosen instance is later dropped from the link, we end
up with an undefined reference.

This change delays this decision until the set of the included files
is known.

Repository:
  rL LLVM

http://reviews.llvm.org/D17900

Files:
  test/tools/gold/X86/Inputs/common.ll
  test/tools/gold/X86/Inputs/common2.ll
  test/tools/gold/X86/common.ll
  tools/gold/gold-plugin.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D17900.49861.patch
Type: text/x-patch
Size: 6753 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160305/e844a3ea/attachment.bin>


More information about the llvm-commits mailing list