[PATCH] D17864: [PGO] Promote indirect calls to conditional direct calls with value-profile

David Li via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 4 15:09:50 PST 2016


davidxl added inline comments.

================
Comment at: lib/Transforms/Instrumentation/PGOInstrumentation.cpp:1223
@@ +1222,3 @@
+
+  StringMap<Function *> ProfNameMap;
+  // Build a profile-function-name to function map.
----------------
See comment in 17895.

There is no need for this map. InstrProfSymtab should return the real function name from the PGOName's MD5 sum (icall target value). Using the real function name, you can directly use:

M.getFunction(RealName) to return the function.


http://reviews.llvm.org/D17864





More information about the llvm-commits mailing list