[PATCH] D17879: [ELF] - Simplify a SymbolBody interface a bit.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 4 09:29:11 PST 2016


davide added a comment.

I'm not entirely convinced this is a big win honestly. ELF has already a type field we can just leave untouched. isTLS() member function is pretty self-explicative. Maybe if you feel is not it can be renamed to isTlsType() but I don't think that's really required. Still, you have to look at how it's set somewhere in the code to understand.
Also, accessing the field directly rather than hiding the information behind a member function, I'm not a huge fan of that either. 
That said, if others like this approach better, I have no strong objections against it.


http://reviews.llvm.org/D17879





More information about the llvm-commits mailing list