[PATCH] D17883: [ASAN] Add support for mips/mips64 android

[Filipe Cabecinhas via llvm-commits]

filcab added a subscriber: filcab.
filcab added a comment.

I have some minor nits.


================
Comment at: lib/sanitizer_common/sanitizer_linux_libcdep.cc:160
@@ -160,1 +159,3 @@
+#if !SANITIZER_FREEBSD && !(SANITIZER_ANDROID && !SANITIZER_MIPS) && \
+  !SANITIZER_GO
 static uptr g_tls_size;
----------------
Can you push the negation inside the parens, please?

================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_posix.cc:1059
@@ -1058,3 +1058,3 @@
 CHECK_STRUCT_SIZE_AND_OFFSET(sigaction, sa_flags);
-#if SANITIZER_LINUX
+#if SANITIZER_LINUX && !(SANITIZER_MIPS32 && SANITIZER_ANDROID)
 CHECK_STRUCT_SIZE_AND_OFFSET(sigaction, sa_restorer);
----------------
Please push the negation inside the parens.

================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_posix.h:82
@@ -82,1 +81,3 @@
+    const unsigned struct_kernel_stat_sz
+                   = (SANITIZER_WORDSIZE == 64) ? 128 : 104;
   #else
----------------
I think using the `FIRST_32_SECOND_64` macro would be even more readable. Even fits on one line.


Repository:
  rL LLVM

http://reviews.llvm.org/D17883