[PATCH] D16201: [ELF/AArch64] - Implemented set of R_AARCH64_TLSDESC_* relocations.

[George Rimar via llvm-commits]

grimar added a comment.

I am sorry that I am pinging this on 4th day and not on 5th day how it declared in llvm polite rules :) I just feel that it is an old enough patch with lot of discussions and it was just forgotten, probably.
But actually it still requires an review and I will appreciate really any comment about it, since it is large and probably needs tweaking.

At least it introduces the approach that adds relocations to the end of .got.plt, after the other ones.
(implemented in void GotPltSection<ELFT>::addTlsDescEntry(SymbolBody *Sym)).
That is the first relocations implemented in lld that requires that.

With this patch the next helloworld apps on AArch64 are running fine:

main.c

  int method();
  int main(void) {
    return method();
  }

shared.c

  int puts(const char *);
  __thread int foo;
  int method() {
    foo = 0;
    puts("Hello, World");
  }

And that was not possible before, so I really believe it is useful to have.


http://reviews.llvm.org/D16201