[lld] r262704 - [ELF][MIPS] Replace S and A arguments of the writeMipsHi16 function by the single argument V. NFC

[Simon Atanasyan via llvm-commits]

Author: atanasyan
Date: Fri Mar  4 04:55:12 2016
New Revision: 262704

URL: http://llvm.org/viewvc/llvm-project?rev=262704&view=rev
Log:
[ELF][MIPS] Replace S and A arguments of the writeMipsHi16 function by the single argument V. NFC

Modified:
    lld/trunk/ELF/Target.cpp

Modified: lld/trunk/ELF/Target.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Target.cpp?rev=262704&r1=262703&r2=262704&view=diff
==============================================================================
--- lld/trunk/ELF/Target.cpp (original)
+++ lld/trunk/ELF/Target.cpp Fri Mar  4 04:55:12 2016
@@ -1641,9 +1641,9 @@ static void applyMipsPcReloc(uint8_t *Lo
 }
 
 template <endianness E>
-static void writeMipsHi16(uint8_t *Loc, uint64_t S, int64_t A) {
+static void writeMipsHi16(uint8_t *Loc, uint64_t V) {
   uint32_t Instr = read32<E>(Loc);
-  write32<E>(Loc, (Instr & 0xffff0000) | mipsHigh(S + A));
+  write32<E>(Loc, (Instr & 0xffff0000) | mipsHigh(V));
 }
 
 template <class ELFT>
@@ -1659,7 +1659,7 @@ void MipsTargetInfo<ELFT>::writePltZero(
   write32<E>(Buf + 28, 0x2718fffe); // subu  $24, $24, 2
   uint64_t Got = Out<ELFT>::GotPlt->getVA();
   uint64_t Plt = Out<ELFT>::Plt->getVA();
-  writeMipsHi16<E>(Buf, Got, 0);
+  writeMipsHi16<E>(Buf, Got);
   relocateOne(Buf + 4, Buf + 8, R_MIPS_LO16, Plt + 4, Got);
   relocateOne(Buf + 8, Buf + 12, R_MIPS_LO16, Plt + 8, Got);
 }
@@ -1673,7 +1673,7 @@ void MipsTargetInfo<ELFT>::writePlt(uint
   write32<E>(Buf + 4, 0x8df90000);  // l[wd] $25, %lo(.got.plt entry)($15)
   write32<E>(Buf + 8, 0x03200008);  // jr    $25
   write32<E>(Buf + 12, 0x25f80000); // addiu $24, $15, %lo(.got.plt entry)
-  writeMipsHi16<E>(Buf, GotEntryAddr, 0);
+  writeMipsHi16<E>(Buf, GotEntryAddr);
   relocateOne(Buf + 4, Buf + 8, R_MIPS_LO16, PltEntryAddr + 4, GotEntryAddr);
   relocateOne(Buf + 12, Buf + 16, R_MIPS_LO16, PltEntryAddr + 8, GotEntryAddr);
 }
@@ -1739,10 +1739,10 @@ void MipsTargetInfo<ELFT>::relocateOne(u
     if (PairedLoc) {
       uint64_t AHL = ((Instr & 0xffff) << 16) +
                      SignExtend64<16>(read32<E>(PairedLoc) & 0xffff);
-      writeMipsHi16<E>(Loc, S, AHL);
+      writeMipsHi16<E>(Loc, S + AHL);
     } else {
       warning("Can't find matching R_MIPS_LO16 relocation for R_MIPS_HI16");
-      writeMipsHi16<E>(Loc, S, 0);
+      writeMipsHi16<E>(Loc, S);
     }
     break;
   }