[PATCH] D17867: [gold] Handle modules that are not included in the link.

[Rafael Ávila de Espíndola via llvm-commits]

rafael added inline comments.

================
Comment at: tools/gold/gold-plugin.cpp:58
@@ -57,1 +57,3 @@
 
+#define LDPT_GET_SYMBOLS_V3 28
+
----------------
you need a ifndef, no?

================
Comment at: tools/gold/gold-plugin.cpp:278
@@ +277,3 @@
+        // Do not override get_symbols_v3 with get_symbols_v2.
+        if (!get_symbols) get_symbols = tv->tv_u.tv_get_symbols;
+        break;
----------------
git-clang-format.

================
Comment at: tools/gold/gold-plugin.cpp:574
@@ -564,1 +573,3 @@
 getFunctionIndexForFile(claimed_file &F, ld_plugin_input_file &Info) {
+  ld_plugin_status status = get_symbols(F.handle, F.syms.size(), &F.syms[0]);
+  if (status == LDPS_NO_SYMS)
----------------
Can this ever happen?


Repository:
  rL LLVM

http://reviews.llvm.org/D17867