[PATCH] D17738: [NVPTX] Fix function identifiers that are invalid in PTX and a bug fix for the case of name collisions.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 3 14:36:47 PST 2016


On 3 March 2016 at 17:01, Arpith Jacob <acjacob at us.ibm.com> wrote:
> arpith-jacob added a comment.
>
> In http://reviews.llvm.org/D17738#367459, @rafael wrote:
>
>> The real stable solution I think is for the IR name to be the final
>>  name. No further mangling involved.
>
>
> Correct me if I am wrong, but I think you are saying that the llvm IR name should only contain chars that are acceptable for *all* targets.

No. It should contain only valid chars for *that target*.

So IR targeting ELF can contain anything but NULL.
IR targeting some odd assembly might have restrictions about using '"'.
IR targeting nvptx cannot use the chars you mentioned.

Cheers,
Rafael


More information about the llvm-commits mailing list