[PATCH] D17041: [X86] Don't assume that a shuffle operand is #0: it isn't for VPERMV.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 3 14:22:48 PST 2016


RKSimon added inline comments.

================
Comment at: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp:5076
@@ -5066,1 +5075,3 @@
+    Ops.push_back(N->getOperand(0));
+    Ops.push_back(N->getOperand(2));
     SDValue MaskNode = N->getOperand(1);
----------------
Just noticed that we're not attempting to detect unary shuffles (which probably explains why you've had so much trouble getting combines to fire):

```
IsUnary = IsFakeUnary = N->getOperand(0) == N->getOperand(2);
```


Repository:
  rL LLVM

http://reviews.llvm.org/D17041





More information about the llvm-commits mailing list