[lld] r262626 - Simplify error handling.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 3 12:56:54 PST 2016


LGTM.

As to Twine, I'd just include Twine.h or move the function definition to
the cpp file, but I think it's up to you.

On Thu, Mar 3, 2016 at 12:53 PM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> What do you think of the attached patch?
>
> Cheers,
> Rafael
>
>
> On 3 March 2016 at 15:37, Rafael EspĂ­ndola <rafael.espindola at gmail.com>
> wrote:
> > On 3 March 2016 at 15:28, Rui Ueyama <ruiu at google.com> wrote:
> >> Maybe we should make all fatal functions noreturn functions, and rename
> >> fatal to check if it may return?
> >>
> >
> > Sounds reasonable. I will give it a try.
> >
> > Cheers,
> > Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160303/d7c7210f/attachment.html>


More information about the llvm-commits mailing list