[PATCH] D16783: [LICM] Store promotion when memory is thread local

[Sanjoy Das via llvm-commits]

sanjoy added a comment.

Overall the logic lgtm.  However, should this be disabled when optimizing for size?


================
Comment at: lib/Transforms/Scalar/LICM.cpp:1012
@@ +1011,3 @@
+        if (!GuaranteedToExecute && !CanSpeculateLoad) {
+          CanSpeculateLoad =
+            isDereferenceableAndAlignedPointer(Store->getPointerOperand(),
----------------
So part of the confusion here for me is that `CanSpeculateLoad` looks like it is really tracking something else.  Does it make sense to rename it to `CanPromoteAliasSet`?


http://reviews.llvm.org/D16783